Update apache client 5.6 + correct gzip handling#1143
Merged
Conversation
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
* support new gzip * get entity details from response * fix gzip test * unused import
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
* support new gzip * get entity details from response * fix gzip test * unused import
l-trotta
added a commit
that referenced
this pull request
Jan 21, 2026
l-trotta
added a commit
that referenced
this pull request
Jan 21, 2026
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-1143-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 94ac310966946b128bc076df0289abc82dfe4e06
# Push it to GitHub
git push --set-upstream origin backport-1143-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-1143-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 94ac310966946b128bc076df0289abc82dfe4e06
# Push it to GitHub
git push --set-upstream origin backport-1143-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0Then, create a pull request where the |
l-trotta
added a commit
that referenced
this pull request
Feb 9, 2026
* support new gzip * get entity details from response * fix gzip test * unused import
l-trotta
added a commit
that referenced
this pull request
Feb 9, 2026
* support new gzip * get entity details from response * fix gzip test * unused import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you @wilkinsona for suggesting the correct way to handle gzip responses and @ok2c for providing a fix for the client not retrieving entity metadata in the response consumer.
The apache httpclient5 version 5.6 introduces a change where it automatically decompresses gzip responses, leaving the original headers untouched. The java client used headers to detect gzip content, which would no longer work, this PR fixes it by checking the entity details instead of the headers.
The PR also updates the default client from httpclient5 5.4 to 5.6.
Closes #1134.